search

sul-dlss / vatican_exhibits

Vatican installation of Spotlight
https://spotlight.vatlib.it
Other
0 stars 1 forks source link

Investigate image upload failure #415

Closed mejackreed closed 5 years ago

mejackreed commented 5 years ago

Reported by Anna on June 4. Investigate HB?

I point you that the function "upload an image" in "Edit Browse Category" > "Thumbnail" doesn't work.
I tried to upload some images from my desktop but they don't appear.
And sometimes it's also happened in "From this exhibit" where there aren't all exhibited items (Domenico Surace -for Path C- told me about some manuscripts like e.g. Vat.gr.154 or Vat.gr.21).
Thanks in advance,
mejackreed commented 5 years ago

I'm thinking perhaps this could be due to session caching and CSRF? Maybe the course of action is to log out and log back in?

jkeck commented 5 years ago

@mejackreed do you know if this is reproducible locally or is this only happening in the production context?

jkeck commented 5 years ago

Okay, I was able to reproduce this locally

jkeck commented 5 years ago

This appear to be an issue w/ turbolinks. I can only reproduce when trying to upload when navigating from another page (doing the upload from a refresh does not return the InvalidAuthenticityToken error). This is all sounding familiar, but not remembering what we did/how we've dealt w/ this before.

mejackreed commented 5 years ago

Ah.. so maybe do this https://github.com/projectblacklight/spotlight/pull/2121/files on this: https://github.com/projectblacklight/spotlight/blob/master/app/views/spotlight/shared/_configuration_sidebar.html.erb ???

jkeck commented 5 years ago

That seems a bit heavy handed, but may be a good last-ditch effort. I'm still trying to determine why this happens in this app and not our own.

mejackreed commented 5 years ago

Fixes in https://github.com/projectblacklight/spotlight/pull/2176