search

sul-dlss / wallscreens

📺 curated experiences for touch-screen installations on the stanford campus
Other
1 stars 0 forks source link

Show attract grid on last card of slideshow. Also... #144

Closed corylown closed 3 years ago

corylown commented 3 years ago

…don't attempt to set background image to undefined; closes #142 and closes #84.

Before:

Screen Shot 2021-11-02 at 4 09 28 PM

After:

Screen Shot 2021-11-02 at 4 08 48 PM
netlify[bot] commented 3 years ago

✔️ Deploy Preview for sul-wallscreens ready!

🔨 Explore the source changes: 4618c8f8177245e22e1ded42efcb17b4f2fff0de

🔍 Inspect the deploy log: https://app.netlify.com/sites/sul-wallscreens/deploys/6181a81efcc8690008d201cb

😎 Browse the preview: https://deploy-preview-144--sul-wallscreens.netlify.app/wallscreens/silicon-valley/video-arcades

cbeer commented 3 years ago

Hm. I imagined just duplicating the <template> on the last slide so it'd need no special handling.

corylown commented 3 years ago

@cbeer that makes sense. I've taken that approach in the latest commit on this branch.

cbeer commented 3 years ago

👍 ; hopefully it gives us a little flexibility and we can avoid tightly coupling those beginning + end states to each experience type 🤷‍♂️