sul-dlss / wallscreens

📺 curated experiences for touch-screen installations on the stanford campus
Other
1 stars 0 forks source link

Oral history video loading but not playing #179

Closed camillevilla closed 2 years ago

camillevilla commented 2 years ago

Chris and I took a look at some of the Silicon Genesis video spottiness this morning (#163 again 😩). When serving up the _site build, the application is able to move the video to the appropriate timestamp for each chapter. However, the video does not begin to play.

One hypothesis: If you open the network tab, you'll notice that Chrome is requesting byte ranges for the local video files. Could the size of the file being loaded be interfering with buffering? For our purposes, it's acceptable for the initial video request to take longer as long as subsequent chapters play without interruption.

thatbudakguy commented 2 years ago

I looked into this a little more — I was able to manually play the video (you can activate it and even unhide the controls from a right-click menu in firefox) and it seemed to work fine, so I became suspicious that it simply wasn't playing.

changing https://github.com/sul-dlss/wallscreens/blob/f11512c2a66b98562a2071988517532aeadc8383/_includes/_nav_first_card.html#L3

to:

<button class="tall button start-button" data-action="{{ page.controller }}#start"> 

made the video play as soon as you clicked the start button, which confirmed my suspicions. it appears that 48891ba introduced a regression: we want the start button to fire oral-history#start for videos, but #next for the other controller types, and extracting a common partial erased that distinction and made everything #next.

there are a couple of ways I can think of to address this, but I bet collectively we can figure out the simplest one.