sul-dlss / wallscreens

📺 curated experiences for touch-screen installations on the stanford campus
Other
1 stars 0 forks source link

hr/border refactor #184

Closed thatbudakguy closed 2 years ago

thatbudakguy commented 2 years ago

this PR addresses some problems with borders on cards & the modal: they had subtle variations in spacing/color, were tied to specific elements using padding/margin, and sometimes didn't appear if the sequence of elements wasn't right (e.g. no experience subtitle).

the new approach uses the <hr/> element so that borders can be explicitly inserted into the html, and are guaranteed to appear regardless of order/placement of surrounding elements. they are all styled using the same CSS.

relatedly, this PR removes some styles that hewed too closely to figma in favor of unifying margins across experiences (for example, the spacing between experience title and subtitle).

netlify[bot] commented 2 years ago

✔️ Deploy Preview for sul-wallscreens ready!

🔨 Explore the source changes: 7758ca288c937d1969e6a8be97d989ec65a40dc2

🔍 Inspect the deploy log: https://app.netlify.com/sites/sul-wallscreens/deploys/618ad4f78784cf00076b7249

😎 Browse the preview: https://deploy-preview-184--sul-wallscreens.netlify.app