Guided tour zoom changed?

sul-dlss / wallscreens

📺 curated experiences for touch-screen installations on the stanford campus

Other

1 stars 0 forks source link

Guided tour zoom changed? #227

Closed ggeisler closed 2 years ago

ggeisler commented 2 years ago

I'm not sure if this is a real issue or whether there's just something weird going on with my local environment or my device-mode strategy of looking at the app.

When running the latest main branch, I see us zoomed in much further than we were a week ago. Does anyone else see what I'm seeing when running main locally?

Current main branch

Notice that:

We're cutting off the tops of heads
On the last stop of the paintings tours, there is visible content area background on the right-side

Examples from last Thursday in Hohbach

camillevilla commented 2 years ago

🤔 My first guess is that this is a result of using the cropped local image #193

corylown commented 2 years ago

Agree this is due to the cropped image derivatives. I would expect both the medical device and networking guided tours to need viewport setting adjustments for each stop with the cropped images.

ggeisler commented 2 years ago

Okay, that makes sense.

So that means the physical wallscreen will show the issue for these tours, since it's serving local images?

Just want to make sure it's clear whether more work needs to be done, and whether y'all want me to close this ticket or ?

camillevilla commented 2 years ago

^-- sorry, that was am ambiguous 👍. Agreed that yes, this is work that needs to be done.

corylown commented 2 years ago

Closed via #233