search

sul-dlss / wallscreens

📺 curated experiences for touch-screen installations on the stanford campus
Other
1 stars 0 forks source link

Create experience type index pages #254

Closed thatbudakguy closed 2 years ago

thatbudakguy commented 2 years ago

this PR closes #244 and implements some parts of #243. it may also make #245 unnecessary (would love feedback on this from @ggeisler).

to select the attractor images for the new experience type index pages, see the metadata in files like _wallscreens/silicon-valley/slideshows.html:

layout: slideshow_index
wallscreen: silicon-valley
attract_images:
  - sf-arcade-1
  - acrobat-and-pdf
  - asteroids-2
...etc

for slideshows, you can specify the key of the images you want to use from any of the slideshows on that wallscreen. this way we don't need multiple copies of thumbnails or attractor images; if the image has already been used in an attractor screen then you just need to list it here.

for guided tours, you just specify the key of the experience whose image you want to use:

layout: guided_tour_index
wallscreen: silicon-valley
attract_experience: networking

for oral histories, it works the same way as specifying the attractor images for the experience:

layout: oral_history_index
wallscreen: silicon-valley
attract_images:
  - images/wallscreens/silicon-valley/silicon-genesis/attract-images/silicon-genesis-01.png
  - images/wallscreens/silicon-valley/silicon-genesis/attract-images/silicon-genesis-02.png
  - images/wallscreens/silicon-valley/silicon-genesis/attract-images/silicon-genesis-03.png
...etc
netlify[bot] commented 2 years ago

✔️ Deploy Preview for sul-wallscreens ready!

🔨 Explore the source changes: 807b6a29ad45c14594d42f28ec3c8e6219838c5e

🔍 Inspect the deploy log: https://app.netlify.com/sites/sul-wallscreens/deploys/619d82d0f615630008d1c397

😎 Browse the preview: https://deploy-preview-254--sul-wallscreens.netlify.app

ggeisler commented 2 years ago

This looks great to me @thatbudakguy, nice work! I'll leave it to the developers to comment on the code strategy but it looks like it offers an easy way to set the attractor screens, etc. And the new functionality all seems to work as we discussed.

One very minor thing, which we could address in a follow-on PR unless you want to update this one: earlier I added a comment in https://github.com/sul-dlss/wallscreens/issues/245#issuecomment-977255616 that specifies the images to use for the slideshows attractors. Overlaps a lot with what's in this PR but I'd still like to update them at some point. But it doesn't have to be this PR if you don't want to mess with it.