search

sul-dlss / wallscreens

📺 curated experiences for touch-screen installations on the stanford campus
Other
1 stars 0 forks source link

Remove testing wallscreens #266

Closed thatbudakguy closed 2 years ago

thatbudakguy commented 2 years ago

this is open for discussion — my sense is that now that we have netlify set up and can create developer/curator-only, non-public wallscreens for testing and development, we no longer need the "testing" category of wallscreens and the test content that was there (e.g. button layouts, etc). if we don't like the results of changes we make, we just elect not to deploy that particular build to a wallscreen.

one argument against getting rid of thise would be if we wanted to have "special" or unique layouts that would belong in this category — for example, something that wasn't a wallscreen at all but was just a page of buttons. but i think we're far enough along in the design process that we no longer need this.

ggeisler commented 2 years ago

As the one who created the testing stuff (that was the original branch, which I just created for working out fundamental layout issues and to help Michael see examples when we were figuring out how we could best handle different source video aspect ratios), I have no objection at all to removing it.

It seems like if we ever have a new need for something like that, we could just add it back in when the time comes.

camillevilla commented 2 years ago

Agreed that we no longer need this. If we need to develop new experiences, we can open a new PR with a dummy YAML file use the associated netlify links. I'm removing the question label on this so it's actionable now.