search

sul-dlss / wallscreens

📺 curated experiences for touch-screen installations on the stanford campus
Other
1 stars 0 forks source link

Evaluate ESLint warnings. #311

Closed corylown closed 2 years ago

corylown commented 2 years ago

Running ESLint on wallscreens bundle exec rake eslint produces a number of warnings that should be addressed or the violated rule should be set to off in .eslint.yml

As an example (there are more warnings in other files):

/Users/corylown/workspace/wallscreens/js/controllers/more-info.js
  1:28  warning  Unexpected use of file extension "js" for "/js/stimulus.js"  import/extensions
  1:28  warning  Do not import modules using an absolute path                 import/no-absolute-path
  1:28  warning  Unable to resolve path to module '/js/stimulus.js'           import/no-unresolved
  8:3   warning  Expected 'this' to be used by class method 'connect'         class-methods-use-this

Full list of rules currently set to warn:

  class-methods-use-this: warn
  consistent-return: warn
  eqeqeq: warn
  import/extensions: warn
  import/no-absolute-path: warn
  import/no-unresolved: warn
  max-len: warn
  no-param-reassign: warn
  no-restricted-globals: warn
  no-return-assign: warn