Closed thatbudakguy closed 2 years ago
✔️ Deploy Preview for sul-wallscreens ready!
🔨 Explore the source changes: 5bb8ad5decbdab56c7b0ab716ab9b825e2140b85
🔍 Inspect the deploy log: https://app.netlify.com/sites/sul-wallscreens/deploys/61ba2c35d01e2400071f66fe
😎 Browse the preview: https://deploy-preview-316--sul-wallscreens.netlify.app/
Here's what I found investigating #289:
:hover
and:focus
styles don't need to be applied when on a wallscreen, since those devices can't hover, and the focus style will "stick" after touching a button which I don't think is what we want. I moved them behind a media query so they'll still work on non-touch devices.:active
style more apparent: thebox-shadow
changes in a way that creates a natural "button depressed" effect, which actually looks OK to me as-is (but @ggeisler should probably take a look and confirm).:active
style doesn't matter, because the page load transition actually happens before we get to see any changes to the button! This seems to happen to everything in the interaction area, as well as "start experience" button. The button to open/close the modal doesn't reload the page, but it also doesn't show the:active
style...maybe because focus is being moved? Not sure what's going on there.:active
style well, which makes sense because they don't cause the page to reload: we just swap in some different content around them. So, if we're OK only showing this style on these buttons, we might not need to do any more here.