WasapiDownloader downloads and validates appropriate files

ndushay commented 7 years ago

this is a shameless green implementation of both the code and the tests.

Please review and indicate if it's a "must fix for merge" comment or a "make a new issue to address this" comment, or just an "FYI" comment.

Resolves #31 Resolves #74 Resolves #64 Resolves #77 Resolves #75

Also splits out WasapiDownloader tests requiring PowerMock from other tests so our jacoco reported test coverage is closer to reality.

ndushay commented 7 years ago

I addressed your line comments, and I will make tickets for:

tests: refactor to WasapiDownloader.getWasapiCrawlSelector() method (and other small tweaks that are easy and make tests more readable)
code: PrintStream instance vars that default to System. out and err (I'm disinclined to do more because it would be better to actually do logging than spend a lot of time on this ... and we already have a ticket for logging)

as for WasapiDownloader class being long ... 200 lines for a class isn't that bad in java -- that's like maybe 125-150 in ruby ... I don't think it screams for help yet.

coveralls commented 7 years ago

Coverage increased (+7.3%) to 88.205% when pulling b9a4b0abfa9ac70c06054e560511e79ae1395dc9 on download-works into 86afe1db0493ebe4f0f1dbdbb0cf184620a03c64 on master.

sul-dlss / wasapi-downloader

WasapiDownloader downloads and validates appropriate files #102