search

sul-dlss / wasapi-downloader

Java application to download WARCs from WASAPI
Other
6 stars 4 forks source link

WasapiDownloader requests list files given settings #71

Closed ndushay closed 7 years ago

ndushay commented 7 years ago

and one teeny refactoring of a test (removing cruft)

Resolves #38

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-9.5%) to 84.472% when pulling ac885db57318154031bbc2b2a6805596916a0675 on filelist-req-hookup into 47119eb447d4719bdbe45e78e41a605dd6145ea0 on master.

ndushay commented 7 years ago

Code coverage reflects that jacoco is confused by powermock.

As result zero code coverage for classes which are loaded by PowerMock class loader ... But right now there is NO WAY TO USE PowerMock with JaCoCo On-the-fly instrumentation.

from https://github.com/powermock/powermock/wiki/Code-coverage-with-JaCoCo

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-9.5%) to 84.472% when pulling 6ed1ec47dac140695bfb6db2d5b6ca3e862e5725 on filelist-req-hookup into 47119eb447d4719bdbe45e78e41a605dd6145ea0 on master.

jmartin-sul commented 7 years ago

LGTM.

would probably be good to have @tingulfsen do the merge, since i paired a bit w/ @ndushay on the tests.