sul-dlss / wasapi-downloader

Java application to download WARCs from WASAPI
Other
6 stars 4 forks source link

integer settings validation improvements #83

Open ndushay opened 7 years ago

ndushay commented 7 years ago

All of the below should give invalid message/error if:

Also, if there is no value, they should be set to ... -1?

This will avoid code like the following in calling methods:

   Integer myInteger = IntegerValidator.getInstance().validate(settings.jobId());
   int jobId = myInteger.intValue();

which instead should be as "easy" as:

int jobId = Integer.parseInt(settings.jobId());

... or settings should return int values directly ...

affected settings: