search

sullyj3 / vim-ftplugin-python

1 stars 4 forks source link

Add end-of-method mappings #8

Closed tpict closed 6 years ago

tpict commented 7 years ago

Currently the ]M/[M behaviour is a bit wonky since it's still looking for C syntax. The mappings I've suggested will match the last non-whitespace character of a line above a class/method definition or above any line at indent level 0.

This matches the ]m/[m behaviour nicely, but chokes on import statements, non-OO structures etc. I think this is acceptable as you see similar behaviour in other filetypes but I'm open to suggestions.

tpict commented 7 years ago

The ]], [[ mappings have already been defined and work well, but I've added corresponding ][, [] motions.

tpict commented 7 years ago

Any more thoughts on this?

sullyj3 commented 7 years ago

Hey, really sorry, I completely forgot about this. Would you possibly interested in taking over as maintainer?

tpict commented 7 years ago

Yeah I would! Do you have to let upstream know? I'm not sure how the transfer works

sullyj3 commented 7 years ago

Sweet, go ahead and replace my name and email with yours at the top of the file, under maintainer. Then email the updated python.vim to Bram. I've let him know.

sullyj3 commented 7 years ago

Let me know once you've done that, and I'll update the repo to indicate that I'm no longer the maintainer.

tpict commented 7 years ago

I've just sent Bram an email. Cheers!