search

sultanalarif / ossbuild

Automatically exported from code.google.com/p/ossbuild
0 stars 0 forks source link

10.7 beta 1 x264enc excludes pthreads support #91

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Encoding with x264 is limited to a single core in 10.7 beta 1.  The compilation 
of the x264 dll is explicitly excluding pthreads.  Trying to track down a 
reason but the commit that includes that change doesn't provide a reason.

Original issue reported on code.google.com by sam72w...@gmail.com on 19 Oct 2010 at 2:47

GoogleCodeExporter commented 8 years ago 
Marking it as a blocker for the release

Original comment by ylatuya on 19 Oct 2010 at 3:38

GoogleCodeExporter commented 8 years ago 
Has this changed from previous releases?

Original comment by david.g.hoyt on 19 Oct 2010 at 4:56

GoogleCodeExporter commented 8 years ago 
It worked in 10.6 afaik.  It was introduced on:

Wed Jun 23 01:20:36 2010
Libraries/Build-All-Windows-x86.sh

Original comment by sam72w...@gmail.com on 19 Oct 2010 at 5:20

GoogleCodeExporter commented 8 years ago 
ohhh, and try using ffdemux_dv ! ffdec_dv instead, that will fix the 
negotiation issue too

Original comment by ylatuya on 19 Oct 2010 at 5:20

GoogleCodeExporter commented 8 years ago 
Sorry, wrong issue

Original comment by ylatuya on 19 Oct 2010 at 5:21

GoogleCodeExporter commented 8 years ago 
This should be fixed as of r912. Please verify so we can close this out.

Original comment by david.g.hoyt on 23 Oct 2010 at 9:12

GoogleCodeExporter commented 8 years ago 
Can you please provide a binary build? I have no build environment set up right 
now.

Original comment by gregory....@gmail.com on 26 Oct 2010 at 2:57

GoogleCodeExporter commented 8 years ago 
The build fails in Visual Studio 2008.  Checking to see if I have a path 
problem.

Original comment by sam72w...@gmail.com on 26 Oct 2010 at 3:04

GoogleCodeExporter commented 8 years ago 
How does the build fail? If it's a "missing libx264-106.dll" issue with WiX, go 
to the <OSSBuild>\Main\GStreamer\Windows\Install\Merge Modules\Dependencies\ 
directory and delete the "obj" folder. WiX caches output there and fails to 
delete the contents of the obj\ directory even when you do a clean.

Original comment by david.g.hoyt on 26 Oct 2010 at 4:13

GoogleCodeExporter commented 8 years ago 
I can provide a beta build, but I've been waiting for ylatuya's UDP patches to 
be applied first. If you don't mind a beta without those patches, I'd be happy 
to provide it.

Original comment by david.g.hoyt on 26 Oct 2010 at 4:17

GoogleCodeExporter commented 8 years ago 
Here's the start of the build errors before I stop the build in VS2008:

>Installing glib-compat.h to 
C:\gstreamer\Build\Windows\Win32\Release\include\gstreamer-0.10\gst
2>        1 file(s) copied.
2>Compiling...
2>gst.c
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(143) : 
error C2143: syntax error : missing '{' before 'const'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(298) : 
error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(299) : 
error C2085: 'g_bit_nth_lsf' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2082: redefinition of formal parameter 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2146: syntax error : missing ',' before identifier 'gint'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2146: syntax error : missing ',' before identifier 'g_bit_nth_msf'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2143: syntax error : missing ';' before '('
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(301) : 
error C2059: syntax error : ')'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(302) : 
error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(302) : 
error C2085: 'g_bit_storage' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(307) : 
error C2085: 'GTrashStack' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(310) : 
error C2016: C requires that a struct or union has at least one member
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(310) : 
error C2061: syntax error : identifier 'GTrashStack'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(311) : 
error C2059: syntax error : '}'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(313) : 
error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(313) : 
error C2143: syntax error : missing ')' before '*'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(313) : 
error C2085: 'g_trash_stack_push' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(313) : 
error C2143: syntax error : missing ';' before '*'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(314) : 
error C2059: syntax error : ')'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(315) : 
error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(315) : 
error C2143: syntax error : missing ')' before '*'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(315) : 
error C2085: 'g_trash_stack_pop' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(315) : 
error C2143: syntax error : missing ';' before '*'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(315) : 
error C2059: syntax error : ')'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(316) : 
error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(316) : 
error C2143: syntax error : missing ')' before '*'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(316) : 
error C2085: 'g_trash_stack_peek' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(316) : 
error C2143: syntax error : missing ';' before '*'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(316) : 
error C2059: syntax error : ')'

Original comment by sam72w...@gmail.com on 27 Oct 2010 at 4:43

GoogleCodeExporter commented 8 years ago 
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(339) 
: error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(339) 
: error C2085: 'g_once_init_enter' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(340) 
: error C2085: 'g_once_init_enter_impl' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(342) 
: error C2085: 'g_once_init_leave' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(344) 
: error C2082: redefinition of formal parameter 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(344) 
: error C2146: syntax error : missing ',' before identifier 'gboolean'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(345) 
: error C2146: syntax error : missing ',' before identifier 'g_once_init_enter'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(345) 
: error C2143: syntax error : missing ';' before '('
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gthread.h(345) 
: error C2059: syntax error : ')'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gstring.h(143) 
: error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gstring.h(146) 
: error C2085: 'g_string_append_c_inline' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gstring.h(146) 
: error C2143: syntax error : missing ';' before '{'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(143) : error 
C2054: expected '(' to follow 'inline'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(143) : error 
C2085: 'gst_g_value_get_boolean_unchecked' : not in formal parameter list
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(143) : error 
C2143: syntax error : missing ';' before '{'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(144) : error 
C2054: expected '(' to follow 'inline'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(144) : error 
C2085: 'gst_g_value_get_int_unchecked' : not in formal parameter list
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(144) : error 
C2143: syntax error : missing ';' before '{'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(145) : error 
C2054: expected '(' to follow 'inline'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(145) : error 
C2085: 'gst_g_value_get_uint_unchecked' : not in formal parameter list
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(145) : error 
C2143: syntax error : missing ';' before '{'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(146) : error 
C2054: expected '(' to follow 'inline'
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(146) : error 
C2085: 'gst_g_value_get_int64_unchecked' : not in formal parameter list
2>c:\gstreamer\main\gstreamer\source\gstreamer\gst\gst_private.h(146) : error 
C2143: syntax error : missing ';' before '{'

Original comment by sam72w...@gmail.com on 27 Oct 2010 at 4:43

GoogleCodeExporter commented 8 years ago 
2>C:\gstreamer\Build\Windows\Win32\Release\include\gstreamer-0.10\gst/gstbuffer.
h(342) : error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Build\Windows\Win32\Release\include\gstreamer-0.10\gst/gstbuffer.
h(344) : error C2085: 'gst_buffer_ref' : not in formal parameter list
2>C:\gstreamer\Build\Windows\Win32\Release\include\gstreamer-0.10\gst/gstbuffer.
h(344) : error C2143: syntax error : missing ';' before '{'
2>C:\gstreamer\Build\Windows\Win32\Release\include\gstreamer-0.10\gst/gstbuffer.
h(361) : error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Build\Windows\Win32\Release\include\gstreamer-0.10\gst/gstbuffer.
h(361) : fatal error C1003: error count exceeds 100; stopping compilation
2>dirent.c
2>parse.c
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(143) : 
error C2143: syntax error : missing '{' before 'const'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(298) : 
error C2054: expected '(' to follow 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(299) : 
error C2085: 'g_bit_nth_lsf' : not in formal parameter list
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2082: redefinition of formal parameter 'inline'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2146: syntax error : missing ',' before identifier 'gint'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2146: syntax error : missing ',' before identifier 'g_bit_nth_msf'
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(300) : 
error C2143: syntax error : missing ';' before '('
2>C:\gstreamer\Shared\Build\Windows\Win32\include\glib-2.0\glib/gutils.h(301) : 
error C2059: syntax error : ')'

Original comment by sam72w...@gmail.com on 27 Oct 2010 at 4:44

GoogleCodeExporter commented 8 years ago 
Can you please a attach a file with the log instead of posting all the errors?

Original comment by ylatuya on 27 Oct 2010 at 4:55

GoogleCodeExporter commented 8 years ago 
log of partial compile errors attached.

Original comment by sam72w...@gmail.com on 27 Oct 2010 at 5:12

Attachments:

GoogleCodeExporter commented 8 years ago 
ylatuya: are you getting these errors? perhaps we should do a clean checkout 
and then compile and see if we come up with the same issue. i've done clean 
builds without a problem.

sam72wong: this really should be a separate issue. it's not specifically 
related to x264 + pthreads (although admittedly it's preventing you from 
testing it out).

Original comment by david.g.hoyt on 27 Oct 2010 at 5:54

GoogleCodeExporter commented 8 years ago 
Checkout and build on a clean system worked fine. I don't know why you're 
experiencing problems. Perhaps you can try and do the same. Let us know if it's 
working.

Original comment by david.g.hoyt on 27 Oct 2010 at 7:09

GoogleCodeExporter commented 8 years ago 
Clean checkout worked for me.  x264enc is multi threaded now as well!

Original comment by sam72w...@gmail.com on 27 Oct 2010 at 9:56

GoogleCodeExporter commented 8 years ago 
Wonderful. (c: Closing...

Original comment by david.g.hoyt on 28 Oct 2010 at 6:08