sultim-t / RayTracedGL1

MIT License
128 stars 29 forks source link

Build steps are a bit off #17

Open camberkenpas opened 2 years ago

camberkenpas commented 2 years ago

These steps don't build anything in the Build/ directory. Everything is built in the base directory of the repo:

mkdir Build
cd Build
cmake ..

Ie,

ls $PWD/libRayTracedGL1.so 
~/RayTracedGL1/libRayTracedGL1.so

When attempting to build prboom-plus-rt, of course it fails with:

gmake[2]: *** ~/RayTracedGL1/Build/RelWithDebInfo/libRayTracedGL1.so', needed by 'prboom-plus'.  Stop.

Though it also seems that prboom-plus-rt should be looking for Release rather than in RelWithDebInfo, but that's somewhat of a separate issue.

I will probably move/copy/link the library to the expected path as a short term workaround, but it would be better to fix the build steps so that they work for everyone without having to muck around.

Unfortunately, I have very low familiarity with cmake.

MartinHowe426 commented 6 months ago

Is there any chance that the build instructions will be updated, please? The glew and glaze subdirectories are empty when the repo is cloned. Following some Google searching, I downloaded glaze from its own repo into the folder, and turned off the options requiring glew. But then gcc complains that format cannot be included in DebugPrint.cpp; apparently std::format is very new and many compilers don't support it yet. I'm ultimately trying to build the prboom RT program on Linux. Is there any likelihood that these issues for this library will be fixed so that it can be built at all?

sultim-t commented 6 months ago

Oh, sorry..

Delete the downloaded folders, and run git command for submodule init/update.

sultim-t commented 6 months ago

I wanted to continue developing the library, but I don't have time anymore for it, sadly. But a friend of mine, @vs-shirokii , somewhat keeps his own fork...

MartinHowe426 commented 6 months ago

Thanks, I'll have a look at the fork. I just wanted to build it as it is, but the format thing in debugprint keeps tripping it up :(