search

sulu / SuluArticleBundle

Bundle for managing localized content-rich entities like blog-posts in the Sulu content management system
MIT License
57 stars 77 forks source link

Run tests with github actions #532

Closed luca-rath closed 3 years ago

luca-rath commented 3 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Run tests with github actions

Why?

To get rid of travis

luca-rath commented 3 years ago

you can see here https://github.com/sulu/SuluArticleBundle/runs/1474716362 and here https://app.circleci.com/pipelines/github/sulu/SuluArticleBundle/435/workflows/5dfb73d3-0403-419d-88ce-689ae7dd81bf/jobs/1054 that the pipeline passes, if browserkit 5.1 is installed

luca-rath commented 3 years ago

@nnatter This pipeline won't pass, because of symfony/browser-kit:5.2 ... Can we merge this?

niklasnatter commented 3 years ago

Okay, going to trust you with that. Looks good otherwise 🙂