search

sulu / SuluArticleBundle

Bundle for managing localized content-rich entities like blog-posts in the Sulu content management system
MIT License
52 stars 77 forks source link

Expand composer lint script and add php-cs-fixer as dev-dependency #541

Closed niklasnatter closed 3 years ago

niklasnatter commented 3 years ago

@luca-rath @alexander-schranz What do you think? Do you see any problems with this?

niklasnatter commented 3 years ago

But in this specific case, if i remember correctly, it can't be executed with --prefer-lowest, because it was implemented in symfony 4.4

Yes, unfortunately the lint:container command is only available in Symfony 4.4 😕

luca-rath commented 3 years ago

Do we still need circleci here? If nobody disagrees I would just remove that

niklasnatter commented 3 years ago

I think circleci is the only place where we set the ARTICLE_TEST_CASE variable at the moment. But would be okay for me to change that in another PR 🙂

alexander-schranz commented 3 years ago

@nnatter would not set ARTICLE_TEST_CASE in this testcases aslong as we do not migrate circleci tests to github actions.

niklasnatter commented 3 years ago

@nnatter would not set ARTICLE_TEST_CASE in this testcases aslong as we do not migrate circleci tests to github actions.

Yes, as said above - would be okay for me to migrate that in the future, but I dont think we need to do it now 🙂

alexander-schranz commented 3 years ago

Looks fine from my side.