search

sulu / SuluArticleBundle

Bundle for managing localized content-rich entities like blog-posts in the Sulu content management system
MIT License
57 stars 77 forks source link

Implement CacheLifetimeBehaviourInterface in ArticleBridge #621

Closed luca-rath closed 2 years ago

luca-rath commented 2 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs sulu/sulu#6814
License MIT

What's in this PR?

Implement CacheLifetimeBehaviourInterface in ArticleBridge

Why?

This allows Sulu's CacheLifetimeEnhancer service to work with ArticleBridge objects. The reason for this is, that the HeadlessWebsiteController can then be used to render articles.

alexander-schranz commented 2 years ago

This should target a new 2.6 branch as it will require sulu/sulu 2.6. Okay 2.5 is not released yet but it need require sulu/sulu:^2.6@dev currently.

luca-rath commented 2 years ago

~This should target a new 2.6 branch as it will require sulu/sulu 2.6.~ Okay 2.5 is not released yet but it need require sulu/sulu:^2.6@dev currently.

nope, therefore I added the fallback interface here

alexander-schranz commented 2 years ago

The php-cs fixer fails we did fix this issue by adopting the php-cs fixer config in our projects to this:

        'phpdoc_to_comment' => [
            'ignored_tags' => ['todo', 'var', 'see', 'phpstan-ignore-next-line'],
        ],