search

sulu / SuluCommunityBundle

Community features like Login, Registration, Password forget/reset for your sulu application.
MIT License
30 stars 39 forks source link

Updated composer.json to support symfony 4 #106

Closed wachterjohannes closed 5 years ago

wachterjohannes commented 6 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT

What's in this PR?

Allows symfony 4 in composer.json

wachterjohannes commented 6 years ago

@alexander-schranz the test fails also in develop so i think we should fix that first

alexander-schranz commented 6 years ago

@wachterjohannes you need to update phpunit see https://github.com/sulu/sulu/pull/3931 and reimplement the 2.0 admin for blacklisting feature

wachterjohannes commented 6 years ago

@alexander-schranz i have done the phpunit update and the admin is not part of this PR - but symfony is not rendering the _token field in the forms (also on develop). do you have an idea why this is happening?

alexander-schranz commented 6 years ago

@alexander-schranz csrf protection is not enabled by default: see https://symfony.com/doc/current/security/csrf.html

Normally sulu does prepend this in the security bundle: https://github.com/sulu/sulu/blob/480347158175b1c37a808209fb947ffa2a2a0d38/src/Sulu/Bundle/SecurityBundle/DependencyInjection/SuluSecurityExtension.php#L74 but think we are now doing this only for admin context accidently, which we should move doing it always. But we should also prepend this in the community bundle.