sulu / SuluFormBundle

Form Bundle for handling Dynamic and Symfony Forms in https://sulu.io
MIT License
81 stars 78 forks source link

sendinblue/api-v3-sdk is abandoned - replace by getbrevo/brevo-php #384

Open steeven-th opened 5 months ago

steeven-th commented 5 months ago
Q A
Bug? yes
New Feature? no
Bundle Version 2.5
Sulu Version 2.5
Browser Version N/A

Actual Behavior

SuluFormBundle is waiting for the "sendinblue/api-v3-sdk" bundle

Expected Behavior

SuluFormBundle must wait for the new "getbrevo/brevo-php" bundle

Steps to Reproduce

Install the new BREVO bundle and test

Capture d’écran 2024-06-03 à 11 31 25

Possible Solutions

In DependencyInjection/SuluFormExtension.php file, line 199, replace this :

if ($config['sendinblue_api_key']) {
   if (!\class_exists(\SendinBlue\Client\Configuration::class)) {
      throw new \LogicException('You need to install the "sendinblue/api-v3-sdk" package to use the sendinblue type.');
   }

   $loader->load('type_sendinblue.xml');
 }

by this

if ($config['sendinblue_api_key']) {
   if (!\class_exists(\Brevo\Client\Configuration::class)) {
      throw new \LogicException('You need to install the "getbrevo/brevo-php" package to use the Brevo type.');
   }

   $loader->load('type_sendinblue.xml');
 }
alexander-schranz commented 5 months ago

We need to find a way todo this without bc breaks. I will add a comment to #374