search

sulu / SuluHeadlessBundle

Bundle that provides controllers and services for using Sulu as headless content management system
MIT License
45 stars 25 forks source link

Allow Symfony 6 #115

Closed chalasr closed 2 years ago

alexander-schranz commented 2 years ago

Replace of static::$container -> static::getContainer() should fix the failing tests for Symfony 6 :)

alexander-schranz commented 2 years ago

Seems routing file still uses the old controller:action instead of controller::action format. Not sure if controller::action is compatible to symfony 4.4. Else I would discuss with our partners if symfony 4.4 support is still required or if we could drop it 🤔

https://github.com/sulu/SuluHeadlessBundle/blob/d5eefc8c1ce2567c1deb651304bd6d1aeedad67a/Resources/config/routing_website.yml#L4

chalasr commented 2 years ago

The recommended notation should be compatible with 4.4 :) PR updated

alexander-schranz commented 2 years ago

Next one 😄 seems to be https://github.com/sulu/SuluHeadlessBundle/blob/77f100c6516c004358bc963b5d4d76e5db3989af/Controller/HeadlessWebsiteController.php#L60. I think this $this->get( need to be now $this->container->get( 🤔

chalasr commented 2 years ago

Fixed along with a remaining self::$container access in tests! 🤞

alexander-schranz commented 2 years ago

Nice @chalasr thank you!