sulu / SuluHeadlessBundle

Bundle that provides controllers and services for using Sulu as headless content management system
MIT License
45 stars 25 forks source link

Add extension placeholder for serialized medias #127

Closed Prokyonn closed 1 year ago

Prokyonn commented 1 year ago

@alexander-schranz @wachterjohannes to prevent the BC break, we could maybe add a config like this:

sulu_headless:
    media:
        use_preferred_extension: true

WDYT?

alexander-schranz commented 1 year ago

@Prokyonn if somebody is using ^0.9 they will not get automatically 0.10, as ^ in pre stable versions is handled like 0.9.* so active update is required and so I'm fine with this bc break and no additional flag.

wachterjohannes commented 1 year ago

@alexander-schranz @wachterjohannes to prevent the BC break, we could maybe add a config like this:

sulu_headless:
    media:
        use_preferred_extension: true

WDYT?

@Prokyonn would also go with a flag and throw a deprecation message when it is not set! else the PR LGTM.

Prokyonn commented 1 year ago

as discussed internally, we'll omit the configuration BC layer, because of

if somebody is using ^0.9 they will not get automatically 0.10, as ^ in pre stable versions is handled like 0.9.* so active update is required and so I'm fine with this bc break and no additional flag.