Add Symfony 7 support - Githubissues

sulu / SuluHeadlessBundle

Bundle that provides controllers and services for using Sulu as headless content management system

MIT License

45 stars 25 forks source link

Add Symfony 7 support #139

Closed TheCadien closed 2 months ago

TheCadien commented 3 months ago

Allow Symfony 7 Packages.

part of https://github.com/sulu/sulu/issues/7413

TheCadien commented 3 months ago

I only have Sulu 2.6 in there at the moment, because otherwise the tests fail due to the change in. https://github.com/sulu/sulu/pull/7238

What do you think @alexander-schranz ? Should we leave it as it is or what is the best way to go about it?

alexander-schranz commented 3 months ago

@TheCadien PS on lowest the order of the result seems to be different maybe a bug in a lower massive search or sulu version?

Bildschirmfoto 2024-05-28 um 14 36 44

The coduo matcher always give a better hint at the top whats wrong:

Bildschirmfoto 2024-05-28 um 14 37 19

So failing Ci is unrelated to coduo matcher version or phpunit versions.

alexander-schranz commented 3 months ago

Maybe ugprade of massive search to https://github.com/massiveart/MassiveSearchBundle/commit/5b06f81092e0b982e1a63e93a93de8b29fe44a13 fixes the lowest part.

TheCadien commented 3 months ago

@TheCadienPS: Die Reihenfolge der Ergebnisse scheint bei niedrigster Stufe anders zu sein, vielleicht ein Fehler in einer weniger umfangreichen Such- oder Sulu-Version?

Der Coduo-Matcher gibt oben immer einen besseren Hinweis darauf, was falsch ist:

Das Fehlschlagen von Ci hat also nichts mit der Coduo-Matcher-Version oder den PHPUnit-Versionen zu tun.

ohhhhh ... didnt seen that ! Thanks :D !

alexander-schranz commented 2 months ago

Looks like we need to fix 8.0 and 8.1 try to make the phpcr bundle requirements more strictly: https://github.com/doctrine/DoctrinePHPCRBundle/pull/404