WIP: Add sourceHost for multi webspace support

sulu / SuluRedirectBundle

Sulu bundle for managing redirects

MIT License

18 stars 19 forks source link

WIP: Add sourceHost for multi webspace support #35

Closed alexander-schranz closed 3 years ago

alexander-schranz commented 5 years ago

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Fixed tickets	fixes #issuenum
Related issues/PRs	#issuenum
License	MIT

What's in this PR?

Add sourceHost for multi webspace support.

Why?

Currently the bundle is not multi webspace compatible as there is no host validation. There should be an optional sourceHost so a redirect can be done created for a specific host.

BC Breaks/Deprecations

See UPGRADE.md

To Do

[ ] Create a documentation PR

choonge commented 3 years ago

Any chance of merging + tagging this? We are looking to use this feature. If some more work needs to happen, perhaps we can assist.

Edit: did not notice the WIP, and had not looked into the code yet. Seems this PR only prepares the database, but does not implement functionality yet. Please see https://github.com/sulu/SuluRedirectBundle/pull/53 for further implementation.

alexander-schranz commented 3 years ago

fixed in #53