search

sulu / SuluRedirectBundle

Sulu bundle for managing redirects
MIT License
18 stars 19 forks source link

change controller to dependency injection #52

Closed akilshadi closed 4 years ago

akilshadi commented 4 years ago

Not compaitble with "sulu/sulu": "^2.1@dev",

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Explain the contents of the PR.

Why?

Which problem does the PR fix? (remove this section if you linked an issue above)

Example Usage

// If you added new features, show examples of how to use them here
// (remove this section if not a new feature)

$foo = new Foo();

// Now we can do
$foo->doSomething();

BC Breaks/Deprecations

Describe BC breaks/deprecations here. (remove this section if not needed)

To Do

akilshadi commented 4 years ago

"sulu/sulu": "^2.1@dev", is not compatible with this version dev-dev

niklasnatter commented 4 years ago

Hey, I just installed and tested this bundle successfully with Sulu 2.1.0. The changes you are proposing were already implemented in #51. Therefore, I will close this.