search

sulu / SuluRedirectBundle

Sulu bundle for managing redirects
MIT License
18 stars 19 forks source link

Allow to configure hostname for redirect #53

Closed choonge closed 3 years ago

choonge commented 3 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Implementation of https://github.com/sulu/SuluRedirectBundle/pull/35

Why?

Allows for redirects by per hostname. Hostname is optional; redirects will fall back to the one without defined sourceHost if no specific redirect exists.

Example Usage

  1. Add redirects in Sulu admin for different hostnames
  2. Verify that the redirects kick in for the different hostnames, even if the source URL is the same
choonge commented 3 years ago

Hi,

No problem at all; we've forked this repo. But it would be neat if the change could make it into the official repo, so we have a bit less maintenance overhead in the future. On the other hand it's not a big problem if you would decide not to merge it after all.

In any case, thanks a lot for taking the time to do the PR review! Your comments have been processed and the branch has been rebased onto 0.x.

Please let me know if you spot any other improvements. Thanks again!

niklasnatter commented 3 years ago

@choonge The team decided to merge this as we wanted to include this feature in the first Sulu 2 version of the bundle anyway. Sorry again for the delay - thanks a lot for working on this 🙂

choonge commented 3 years ago

@nnatter Great news, thank you! When ready, could you please create a new tag? Thanks again!

niklasnatter commented 3 years ago

We would like to merge #34 and #36 before creating a tag. But after that, we will tag a final Sulu 1 release 🙂