sulu / SuluRedirectBundle

Sulu bundle for managing redirects
MIT License
18 stars 19 forks source link

Lowercasing target URL can lead to non-working redirect #78

Closed ngrie closed 1 year ago

ngrie commented 2 years ago
Q A
Bug? yes
New Feature? no
Sulu Version 2.4.0
SuluRedirect Version 2.0.2
Browser Version -

Actual Behavior

Since #63 the redirect bundle lowercases all target URLs, which can make the whole redirect useless depending on whether the target application's URLs are case sensitive or not.

Expected Behavior

The target URL is adopted as it is entered.

Steps to Reproduce

Add a redirect to e.g. a Spotify playlist URL (which is case sensitive). When opening the source URL, the Spotify page you get redirected to will load forever or show an error page.

Possible Solutions

Remove the mb_strtolower call for the target URL.

Would you accept this change or would this be considered a BC break?

luca-rath commented 1 year ago

This has been fixed in #85