search

sulu / SuluThemeBundle

MIT License
18 stars 15 forks source link

Refactored ImageFormatCompilerPass to meet the requirements of the new image formats definition #2

Closed mmsbrggr closed 8 years ago

mmsbrggr commented 8 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs https://github.com/sulu/sulu/pull/2845
License MIT
Documentation PR -

What's in this PR?

There is PR (https://github.com/sulu/sulu/pull/2845) which introduces a new version for the definition of image-formats. This PR updates the ThemeBundle to meet the requirements of the new version.

mmsbrggr commented 8 years ago

Note that the way in which the image-formats of this bundle are added is not optimal. The linked PR in sulu/sulu defines a configuration through which individual bundles can add their files via prependExtension. However the ThemeBundle has to access various services to construct the paths to the image-format files.

I created an issue for that matter: https://github.com/sulu/SuluThemeBundle/issues/3