search

sulu / SuluThemeBundle

MIT License
18 stars 15 forks source link

Fix preview webspace without theme #25

Closed plozmun closed 3 years ago

plozmun commented 3 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs -
License MIT

What's in this PR?

Fix for preview when no theme is specified in a webspace.

Why?

If no theme is specified default template dir must be used

Example Usage

Create a webspace without theme and try to preview a page in admin.

plozmun commented 3 years ago

Maybe related to #15 ?

alexander-schranz commented 3 years ago

The CI error is because sulu supports now a new version of gedmo extension. The following need to be done in the test setup: https://github.com/sulu/SuluArticleBundle/commit/1745c7ae215c7e3a513ed32080c1def08a805fdc

plozmun commented 3 years ago

The CI error is because sulu supports now a new version of gedmo extension. The following need to be done in the test setup: sulu/SuluArticleBundle@1745c7a

PR ready in #26

alexander-schranz commented 3 years ago

@plozmun thank you. Can you rebase this one?

alexander-schranz commented 3 years ago

@plozmun Thank you!

alexander-schranz commented 3 years ago

Released as 3.0.1

plozmun commented 3 years ago

Thanks @alexander-schranz !