Fix for including theme image format config

sulu / SuluThemeBundle

MIT License

18 stars 15 forks source link

Fix for including theme image format config #34

Open websmurf opened 1 year ago

websmurf commented 1 year ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	fixes #16
License	MIT

What's in this PR?

In the documentation here is described here:

Or when you use the SuluThemeBundle you can define the formats in your theme folder:

path/to//config/image-formats.xml

This doesn't appear to work as described

Why?

This pull requests will add the described option and will allow an image-format.xml file per theme.

SebTM commented 1 year ago

Maybe we should extend the existing tests to ensure it doesn't break in the future?

websmurf commented 1 year ago

What would be needed in order to get this code review moving?

Mocking a file_exists check will be a bit difficult in tests right? Plus I have zero experience with Prophecy (only phpunit and mockery), so will have to have some pointers how to get started :-)