search

sulu / skeleton

Project template for starting your new project based on the Sulu content management system
https://sulu.io
MIT License
261 stars 81 forks source link

Enable legacy-peer-deps in .npmrc file to display helpful error message when using npm 7 #135

Closed niklasnatter closed 3 years ago

niklasnatter commented 3 years ago
Q A
Related issues/PRs https://github.com/sulu/sulu/pull/6200 https://github.com/sulu/skeleton/issues/133

What's in this PR?

This PR enables the legacy-peer-deps setting in the assets/admin/.npmrc file.

Why?

Because npm tries to resolve the dependency tree before validating the engines section of the pacakge.json. Because of this, users see a confusing dependency tree error message instead of the message that sulu is not compatible with npm 7. See https://github.com/sulu/skeleton/issues/133