search

sulu / skeleton

Project template for starting your new project based on the Sulu content management system
https://sulu.io
MIT License
261 stars 81 forks source link

Update recipes with mysql based doctrine docker compose file #145

Closed alexander-schranz closed 2 years ago

alexander-schranz commented 2 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs replaces #144
License MIT
Documentation PR sulu/sulu-docs#prnum

What's in this PR?

Update recipes with mysql based doctrine docker compose file.

Why?

Else symfony will create a postgresql based docker compose file.

Possible Solutions

alexander-schranz commented 2 years ago

As discussed we will wait here for feedback from the community, if we go with postgresql or mysql.

BaptisteCrouzet commented 2 years ago

As seen on many benchmarks, like this one https://itnext.io/benchmark-databases-in-docker-mysql-postgresql-sql-server-7b129368eed7 PostgreSQL isn't a bad default choice when looking at read/write/update time, often really faster than MySQL. I'm used to MySQL but I would be okay to switch on Postgre 🙂

sanhofman commented 2 years ago

We use MySQL as our go-to database, but lately receive more requests for PostgreSQL.

Are there benchmarks for Sulu with PostgreSQL vs MySQL? Could be interesting.

But overall, definitely fine to switch to PostgreSQL as default.

alexander-schranz commented 2 years ago

We sadly do not yet have any benchmarks yes about postgresql. If somebody is using postgresql, would be great if they could give us some stats about it to performance to mysql 8 with phpcr.

We only did get once feedback when somebody did upgrade form PostgrSQL form 9.6 to 12 that the contact list which was just a indexed join was getting really slow. But we could not find out why and I'm not sure if that does still exist as it was a really early version of postgresql 12 at that time.

alexander-schranz commented 2 years ago

From our Partner connectiv we got the response that they would prefer MySQL as default in Sulu.

alexander-schranz commented 2 years ago

A third option would be disable docker support by default in Sulu Skeleton by setting the extra -> symfony -> docker config to false: https://github.com/symfony/flex/pull/821

niklasnatter commented 2 years ago

We decided to include a docker-compose.yml file with a mysql database service for the moment. The reason is that we do not have enough experience with PostgreSQL to include this as default choice confidently at the moment. Still, we want to fully support PostgreSQL and we are open to change the default choice in the future 🙂

alexander-schranz commented 2 years ago

Please see this discussion not as closed. We are still searching here for feedback. If somebody have experience performance on PHPCR based content mysql vs postgresql would be great.