search

sulu / skeleton

Project template for starting your new project based on the Sulu content management system
https://sulu.io
MIT License
261 stars 81 forks source link

use roles vs role in security.yaml access_control #192

Closed rogamoore closed 2 years ago

rogamoore commented 2 years ago
Q A
Bug fix? not sure
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

For consistency and to follow the Symfony Docs (https://symfony.com/doc/current/security/access_control.html#2-access-enforcement) roles should be used. From what I saw it seems to work with role too - probably because of a call to fixXmlConfig in the Symfony Security Bundle.

alexander-schranz commented 2 years ago

@rogamoore Make sense. Thank you 👍

rogamoore commented 2 years ago

Quick as always, thanks! 🙂