Closed alexander-schranz closed 8 months ago
@prokyonn in bigger project also we did run into memory issues. But the main point why I disable the rules is that rector
outputs a huge warning:
https://getrector.com/blog/5-common-mistakes-in-rector-config-and-how-to-avoid-them
The alternative would be define the jump from 6.0
-> 6.3
only:
$rectorConfig->sets([
SymfonySetList::SYMFONY_61,
SymfonySetList::SYMFONY_62,
SymfonySetList::SYMFONY_63,
SymfonySetList::SYMFONY_CODE_QUALITY,
SymfonySetList::SYMFONY_CONSTRUCTOR_INJECTION,
]);
What's in this PR?
Follow Rector best practices by disable some SetLists.
Why?
@tomasvotruba recommends disabling this kind of sets for the daily CI and only activate them temporary when doing uprades.