search

sulu / sulu-docs

Sulu documentation
https://docs.sulu.io
22 stars 116 forks source link

Updating single sign on documentation #797

Closed tic984 closed 4 months ago

tic984 commented 5 months ago

Updating single sign on documentation with information on explicitly setting the domain via configuration.

Q A
License MIT

What's in this PR?

This PR introduces an amendment to the documentation regarding Single Sign-On (SSO) configuration in the Sulu project.

Why?

The existing documentation lacked clarity regarding the configuration option for specifying the domain. This PR addresses this issue by providing explicit instructions on how to configure the domain key, which is essential for seamless integration with Single Sign-On providers. Additionally, it includes a note highlighting the importance of specifying the domain key to avoid potential normalization issues.

I enountered the issue while following the sample in the documentation and provided a domain with "-" in it.

alexander-schranz commented 4 months ago

@tic984 Thx for the pull request but this is more a bug then a documentation part. This will be fixed in: https://github.com/sulu/sulu/pull/7421. Still thank you for your pull request.

alexander-schranz commented 4 months ago

Thank you still for your pr. added you as a co authored of https://github.com/sulu/sulu/pull/7421 which should fix the issue with - in future.