search

sulu / sulu-standard

This repository is not longer the recommended way to start a sulu project. Use:
https://github.com/sulu/skeleton
MIT License
614 stars 106 forks source link

Remove weird dependencies among Sulu bundles #341

Open danrot opened 9 years ago

danrot commented 9 years ago

Since I am currently changing dependencies, I am discovering some dependencies, which are hard to maintain, and we should try to remove them.

SuluContactBundle -> SuluMediaBundle which causes the circular dependency SuluTagBundle -> SuluMediaBundle (could be solved with a separate SuluCRMBundle?)

SuluSecurityBundle -> SuluContactBundle (I know this dependency is hard to remove, but maybe we should talk about that)

SuluContentBundle -> SuluWebsiteBundle (because of Preview, should actually be located in SuluWebsiteBundle, or even in a separate bundle)

SuluTestBundle -> DoctrineBundle (really necessary? Needs more detailed check with other bundles)

I also found an interesting php script, which draws dependencies for us, however I am not sure if the big graph is useful to read: https://github.com/clue/graph-composer#install

Maybe it would also help to build a kind of layers of bundles and visualize that, where only one direction of dependencies is allowed.

danrot commented 9 years ago

In general also in the standard installation can be reduced even more like described in https://github.com/sulu-cmf/sulu-standard/issues/112#issuecomment-60090404