search

sulu / sulu-standard

This repository is not longer the recommended way to start a sulu project. Use:
https://github.com/sulu/skeleton
MIT License
614 stars 106 forks source link

Move the body of the AbstractKernel to sulu/sulu #389

Open dantleech opened 9 years ago

dantleech commented 9 years ago

We should have a DefaultKernel or something in sulu/sulu which contains all of the bundle instantiations. The standard edition kernel would then extend this class.

This will enable us to handle our bundle dependencies in the main library instead of client installations which may not get updated (who wants to merge and fix conflicts in their setups? especially when they do not understand the changes).

Users would then be able to extend a different class if for some reason they do not want a certain bundle enabled (or we could add a method to explicitly disable bundles).

danrot commented 9 years ago

+1

wachterjohannes commented 9 years ago

+1

matejvelikonja commented 9 years ago

I think it the methods in AbstractKernel should be just moved to SuluKernel. I also suggest adding special cache and log dirs if the environment is Vagrant (then it should be moved to /dev/shm) for better performance. Like the Sylius guys did it here https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/CoreBundle/Kernel/Kernel.php#L130-157

danrot commented 9 years ago

Probably makes sense. And I also like the vagrant solution from Sylius, I think we should do it the same way. /cc @philipheimboeck

chirimoya commented 9 years ago

+1

wachterjohannes commented 9 years ago

+1

chirimoya commented 8 years ago

https://github.com/sulu-io/sulu-standard/issues/621

danrot commented 8 years ago

@chirimoya Doesn't the linked issue replace this one? We would remove the AbstractKernel there, won't we?

chirimoya commented 8 years ago

@danrot Not sure if it replaces, I think they are related.

webmozart commented 8 years ago

I think they are related, too. However, do we really provide a prebuilt kernel for our users? That means that changing that kernel automatically changes all applications using that kernel. I think that's a bit risky.

danrot commented 8 years ago

I also think that makes less sense, if we change to a single kernel setup and stop pulling from sulu-standard. So I'd rather not do that anymore.

sagikazarmark commented 8 years ago

I don't really like the idea of having vagrant related stuff right in the kernel. It is a development detail. There are better ways for doing this IMO, which does not effect the application itself.