search

sum12 / rqlite-django

Django Backend for the Rqlite Database
MIT License
3 stars 1 forks source link

Deduplicate code by extending Django's SQLite backend #1

Open alanjds opened 6 years ago

alanjds commented 6 years ago

As lots of code seems to be copy-pasted from Django's SQLite backend, what about deduplicate it by extending instead of copy-pasting?

This way, bugfixes in SQLite upstream would propagate, and would be clearer what code is new and what is Django's one.

sum12 commented 6 years ago

Yes, as you have noticed. It's just a copy with some fixes here and there.

I didn't want to invest time in keeping it clean unless the related PRs get accepted.

So i will wait till then and clean this duplication.

On Fri, Jul 13, 2018, 18:32 Alan Justino da Silva notifications@github.com wrote:

As lots of code seems to be copy-pasted from Django's SQLite backend, what about deduplicate it by extending instead of copy-pasting?

This way, bugfixes in SQLite upstream would propagate, and would be clearer what code is new and what is Django's one.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sum12/rqlite-django/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ADIhEw4VRaPyZ3sK_ZflkjFgkDGAWyM-ks5uGMubgaJpZM4VPLd_ .