search

sumanj / frankencert

Frankencert - Adversarial Testing of Certificate Validation in SSL/TLS Implementations
175 stars 54 forks source link

only version 1 certificates? #14

Open nulman opened 3 years ago

nulman commented 3 years ago

All certificates generate as "Version: 1 (0x0)"

Looking at the code, I see that cert.set_version is not used anywhere so it defaults to 0 (version 1). I think perhaps this should also be either inferred from the read certs, passed as a config option or at least default to cert.set_version(2) (version 3) anywhere after this line https://github.com/sumanj/frankencert/blob/5bbaae85cab35882dec1672ef037a42e29180b40/frankengen/franken_core.py#L31

tomato42 commented 3 years ago

Doesn't the code default to version 3 (0x2) when the extensions are present?

nulman commented 3 years ago

It does not appear to be so