search

sumatrapdfreader / sumatrapdf

SumatraPDF reader
http://www.sumatrapdfreader.org
GNU General Public License v3.0
13.36k stars 1.7k forks source link

Display annotations in RTL #4393

Open H5820121 opened 1 month ago

H5820121 commented 1 month ago

@GitHubRulesOK This topic has already been opened a long time ago by me and others, but I think it has been forgotten, and I do not intend to open a duplicate topic but only to remind the developer of this important topic now that it is engaged in the development of version 3.6. Adobe Acrobat and PDF-XChange Editor respect annotations written in RTL and display them correctly, even a annotation written in RTL in PDF-XChange Editor is displayed as RTL in Adobe Acrobat and vice versa, and only SumatraPDF displays everything in LTR. I would be very happy for this important issue to be brought to the attention of the developer who is currently developing version 3.6, thank you!

kjk commented 1 month ago

I need at least one test document that shows the problem.

Also, please link to this topic has already been opened you referenced.

H5820121 commented 1 month ago

@kjk I'm attaching a sample document here. The annotation was written in RTL in PDF-XChange Editor, but it is also displayed RTL in Adobe Acrobat. Only in SumatraPDF it is displayed LTR. Thank you! Document1.pdf

GitHubRulesOK commented 1 month ago

Hmm there are problems with a Microsoft focused view of coded usage I see

image

Which seems to translate well except Google and Microsoft insist the surround be American. image

image

H5820121 commented 1 month ago

@GitHubRulesOK But PDF-XChange Editor and Adobe Acrobat display automatically in RTL, and also in the annotation tooltip they display in RTL. And SumatraPDF also annotation tooltip displays LTR, and in the tooltip user can do nothing.

‫בתאריך יום ג׳, 23 ביולי 2024 ב-18:23 מאת ‪GitHubRulesOK‬‏ <‪ @.***‬‏>:‬

Hmm there are problems with a Microsoft focused view of coded usage I see

image.png (view on web) https://github.com/user-attachments/assets/9b314ff6-2d1a-45fa-80a4-9526104d966c

Which seems to translate well except Google and Microsoft insist the surround be American. image.png (view on web) https://github.com/user-attachments/assets/5c2b31cf-b931-4c6d-aee9-f19a5563dd6c

— Reply to this email directly, view it on GitHub https://github.com/sumatrapdfreader/sumatrapdf/issues/4393#issuecomment-2245550516, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFMFTFNLKEUQHRSMRDJ6L3ZNZYN7AVCNFSM6AAAAABLJ56RM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGU2TANJRGY . You are receiving this because you authored the thread.Message ID: @.***>

kjk commented 1 month ago

Not a trivial fix.

Those are displayed in tooltips. Have to figure out how display tooltip in rtl.

We currently don't propagate info about rtl status of annotation, it's just text. So have to figure out how to ask mupdf if annotation is rtl and then change the interface to either provide isRtl as a flag or more generic implement OnHover and OnClick virtual functions that can do the right thing.

H5820121 commented 1 week ago

@kjk "Not a trivial fix" I think, as well as the opinion of my colleagues, that if there was a setting for ALL annotations to be displayed in RTL, that would also be very helpful. It seems to me that such a general definition of all the annotations is a little easier to do. I know that this takes time and you are very busy, but I ask that you take into consideration this that it is needed by millions of people who use RTL, Hebrew Arabic and Persian, and all countries in the Middle East. Thanks!

‫בתאריך יום ג׳, 23 ביולי 2024 ב-20:27 מאת ‪Krzysztof Kowalczyk‬‏ <‪ @.***‬‏>:‬

Not a trivial fix.

Those are displayed in tooltips. Have to figure out how display tooltip in rtl.

We currently don't propagate info about rtl status of annotation, it's just text. So have to figure out how to ask mupdf if annotation is rtl and then change the interface to either provide isRtl as a flag or more generic implement OnHover and OnClick virtual functions that can do the right thing.

— Reply to this email directly, view it on GitHub https://github.com/sumatrapdfreader/sumatrapdf/issues/4393#issuecomment-2245828171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFMFTHXVXBQTWGPVZQA26DZN2G63AVCNFSM6AAAAABLJ56RM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVHAZDQMJXGE . You are receiving this because you authored the thread.Message ID: @.***>