search

sumcumo / vue-datepicker

A datepicker Vue component. Compatible with Vue 2.x.
https://sumcumo.github.io/vue-datepicker/
Apache License 2.0
75 stars 21 forks source link

Vue 3 compatibility #78

Open adambartosiewicz opened 3 years ago

adambartosiewicz commented 3 years ago

Any plans for updating the code to be compatible with Vue 3?

MrWook commented 3 years ago

Hey good question.

Currently i'm mainly working with nuxt which is not compatible with vue3 yet this means i'm not really into vue3 at the moment but i know there is a library that will build a vue3 compatible file out of a vue2 library i just don't know how it is called anymore. If i find it again, i will check it out.

@mst101 is constantly improving this package and is in the process of adding keyboard support. This means that i will definitely wait till he finishes it because that is a big complicated feature.

hisuwh commented 2 years ago

@MrWook are you thinking of vue-demi?

wadday commented 2 years ago

here is a snapshot of vuejs-datepicker implemented for Vue 3. uses all the functionalities in vuejs-datepicker.

my main objective was to workaround to use in Vue 3 however, during the implementation I've also added one of the biggest issues I had on my office project. On day views every month numbers of days are different and the picker resizes the height accordingly.

Day view Month View Year View
image image image

currently, this is not on a public repository, however, if anyone wants to contribute to making this as a package, I am ready to push to GitHub.

hisuwh commented 2 years ago

@wadday is this something you have been developing separately to this package?

wadday commented 2 years ago

@wadday is this something you have been developing separately to this package?

Idea is to make it public as a separate package for Vue 3. However, my schedule is very tight at the moment.

wadday commented 2 years ago

those who are looking for Vue 3 version check this out. https://github.com/shubhadip/vuejs3-datepicker

acallaghan commented 2 years ago

Any movement on Vue 3 @MrWook? Nuxt is compatible with Vue 3 now

acallaghan commented 2 years ago

Ah i see this commit - https://github.com/sumcumo/vue-datepicker/commit/46bab513fc584f0266f3e1d78e518c72876a2376

Let me know if you need any help at all, happy to help out here

brandonburkett commented 1 year ago

We're finally making the vue3 upgrade soon. Is this still a pending feature or will it become a separate package?

mst101 commented 1 year ago

I've been a bit distracted recently learning Nuxt (which I'm enjoying very much...), but I have also been working locally on upgrading this project to Vue 3. It's working, but I still have issues with getting some unit tests to pass. There's also more to be done with setting up a v3 version of the e2e tests + the actual build.

I will upload my work-in-progress asap - and will welcome any help you (@acallaghan, @brandonburkett, or others - and of course @MrWook) may be able to provide to get v3 off the ground!

mst101 commented 1 year ago

Please see #185. We're getting there, but I could do with some help getting these 6 unit tests to pass!

mst101 commented 1 year ago

Good news! All tests are all passing now - upgrading vue-test-utils from v2.1 to v2.2 solves the problem.

All that's left now (as far as I'm aware) is to update the Cleave & Vee-validate integrations in Vuepress 2 docs...

brandonburkett commented 1 year ago

Our vue3 transition got pushed until next month, but can help check how it works in our env then.

roelVerdonschot commented 1 year ago

Any update on this?