143 users controller decorators

halfghaninne commented 7 years ago

Only really creating this pull request to ask questions.

I don't think there is work to be done on this issue, but I'm not sure.

Question from PR:

I don't think there is anything in the two user views that necessitates use of a decorator, or is that not the point? Should I always be using decorators? I don't really understand best practice here.

Files to examine:

app/controllers/users_controller.rb
app/views/users/index.html.erb
app/views/users/show.html.erb

halfghaninne commented 6 years ago

@sumeetjain I think my question here still stands!

sumeetjain commented 6 years ago

@halfghaninne Sorry for delay in responding. I need to tweak my GH notification settings.

Unfortunately, I'm not sure what the answer is. It's been so long, and I've lost my frame of mind from when we were working on this. I think probably the best way to move forward is not to worry too much about using decorators and instead see if any pain points emerge from writing code for new features (which is probably the more interesting kind of work too). If the code in this PR makes sense to you, and if it hasn't broken functionality, you're welcome to merge it.

Let me know if the above is not helpful. Going to need some time and feedback from you to calibrate how I think about the code here.

sumeetjain / outcomes-tracker

143 users controller decorators #157