search

sumerc / yappi

Yet Another Python Profiler, but this time multithreading, asyncio and gevent aware.
MIT License
1.45k stars 73 forks source link

add gevent test, based on existing asyncio test #52

Closed mguijarr closed 4 years ago

mguijarr commented 4 years ago

Following conversation in issue https://github.com/sumerc/yappi/issues/47, here is a first attempt of adding tests for the gevent profiling feature based on the existing asyncio test.

The traces have not been updated, yet, since the basic functionality is missing ; this is more to see how far it can go and if it is worth investing more time I would happily try to contribute more

sumerc commented 4 years ago

Following conversation in issue #47, here is a first attempt of adding tests for the gevent profiling feature based on the existing asyncio test.

Awesome! So, these tests cover both multi/single threaded cases right? Just like asyncio?

The traces have not been updated, yet, since the basic functionality is missing ; this is more to see how far it can go and if it is worth investing more time I would happily try to contribute more

Sure. I have been thinking about this for a while. I will start implementation as soon as possible, but finding time might be a bit tricky these days. Stay tuned!

I am using master for hotfixes, so it would be better to add this to another branch. I opened gevent-profiling branch and applied your changes there, so closing this PR. Let's use that branch to develop this.

Thanks for all your help!

sumerc commented 4 years ago

Closing this as https://github.com/sumerc/yappi/pull/53 is opened.