Pull request: Update Japanese Translation on 29 Aug, 2021

sumghai / MedPod

Advanced regenerative medical beds for RimWorld

Other

14 stars 15 forks source link

Pull request: Update Japanese Translation on 29 Aug, 2021 #52

Closed Proxyer closed 2 years ago

Proxyer commented 2 years ago

resend pull request.

Proxyer commented 2 years ago

At least 1 approving review is required by reviewers with write access.
Merging can be performed automatically with 1 approving review.
This is looks like a approve problem.

Proxyer commented 2 years ago

Um, you still haven't changed 高級 back to Lux. Also, if you need to fix a Pull Request, you don't need to close it and start over - just push new commits to the existing PR.

Probably the Japanese translation of MedPod Lux is not the cause of the error. It is actually displayed without any problem on the in-game screen. It could also be built. https://steamcommunity.com/sharedfiles/filedetails/?id=2588210540

Proxyer commented 2 years ago

I went back to Lux, but I still get the error. It was not the cause of the problem.

sumghai commented 2 years ago

* At least 1 approving review is required by reviewers with write access.

* Merging can be performed automatically with 1 approving review.

* This is looks like a approve problem.

This is because (at that time) I hadn't approved the changes yet. Now that the MedPod Lux name has been fixed, I will approve it now.

sumghai commented 2 years ago

@Proxyer - Just a heads-up that since translation fixes usually aren't mission-critical, I'll wait until the next update before officially releasing these changes to the public.

Proxyer commented 2 years ago

I undersand. Thank you for your support.