sumghai / MedPod

Advanced regenerative medical beds for RimWorld
Other
14 stars 15 forks source link

Save our Ship 2.7 compability #96

Open Gryby64 opened 2 weeks ago

Gryby64 commented 2 weeks ago

Problem: Save our Ship 2, after moving ship all medpods turn green so they no longer can be used

Workaround: Reinstalling the building (rotating in place)

Suggested solution: If save our ship 2 is installed show "Medical" gizmo

RimWorld DLCs loaded: all MedPod mod version: 1.5.33 MedPod mod downloaded from: steam Your mod list: harmony, core, dlc, hugslib, medpod, vehicles framework, SOS 2.7

I hereby verify that:

sumghai commented 2 weeks ago

Hmm, this does sound rather peculiar.

I disabled the Medical gizmo from MedPod beds, because MedPods are always meant to be for medical use only, and I wanted to prevent players from accidentally turning them into regular beds.

Re-enabling the gizmo just to provide players a way to work around this specific SOS2 bug isn't ideal, as it re-introduces the aforementioned problem. A more robust approach would be to understand why moving a ship that contains a MedPod resets the bed type/state, and to figure out a way to compensate for that under the hood without requiring player intervention.

@KentHaeger - any particular reason why SOS2 may cause a bed to change its type/state from medical to non-medical?

FGRemastered commented 1 week ago

I think SOS2 re-generates the map when you move the ship, causing all buildings to be unclaimed for a moment and any unclaimed bed defaults to general use.

sumghai commented 1 week ago

I think SOS2 re-generates the map when you move the ship, causing all buildings to be unclaimed for a moment and any unclaimed bed defaults to general use.

I had an inkling this was the case, but I'm trying to confirm with the current developers/maintainers of SOS2.

sumghai commented 2 days ago

According to Thain (via Discord):

It's kindof an ongoing issue between SOS2 and other mods. A solution evades us so far, as some mods just struggle to transfer settings between buildings, including container mod display states (the stuff transfers and the stack size transfers, but not the display which reads as default stack size until the game is reloaded. Stuff like that.)

As for whether this was something that should be fixed on MedPod's side, or on SOS2's side:

I'll get back to you. There's a solution but I'll have to dig it out. Was added right before the SonicTHI fiasco, which was so stressful it just wiped all memory from my brain.

So I'll leave this issue open for now, pending an update from Thain and the rest of the SOS2 dev team.