search

sumghai / SDHI_ServiceModuleSystem

Parts pack for Kerbal Space Program that consists of a stockalike Service Module and accessories inspired by NASA’s Orion MPCV, and designed specifically for use with the stock Mk1-3 Command Pod.
Other
23 stars 9 forks source link

Use of :FINAL in MM patches #118

Closed RedAV8R closed 7 years ago

RedAV8R commented 7 years ago

Not sure if it's intended or not, but the use of :FINAL in your MM patches is hard for others to modify things. I do understand the want to prevent others from doing so and the troubleshooting involved. If I submit a PR to replace them would you be receptive to that?

The TACLS patch is outdated as well.

sumghai commented 7 years ago

Not sure if it's intended or not, but the use of :FINAL in your MM patches is hard for others to modify things. I do understand the want to prevent others from doing so and the troubleshooting involved. If I submit a PR to replace them would you be receptive to that?

Some of the instances are deliberately meant to be final (e.g. the patch that adds the umbilical model to the pod, the life support patches).

I can definitely consider PRs on a case-by-case basis, but you'll need to justify each and every modification.

The TACLS patch is outdated as well.

Has the current maintainer changed things around yet again?

Might be good to post this as a separate issue.

sumghai commented 7 years ago

@RedAV8R, I am waiting on your pull requests.

RedAV8R commented 7 years ago

119 There you go. Sorry about the wait.

sumghai commented 7 years ago

As per discussions in #119, PR accepted and merged with thanks!