sumghai / SDHI_ServiceModuleSystem

Parts pack for Kerbal Space Program that consists of a stockalike Service Module and accessories inspired by NASA’s Orion MPCV, and designed specifically for use with the stock Mk1-3 Command Pod.
Other
23 stars 9 forks source link

ModuleGenerator/TacGenericConverter causes SM decoupler to automatically fire #8

Closed johnwayne1930 closed 10 years ago

johnwayne1930 commented 10 years ago

I tried out the "SDHI_SMS_MMPatch_TACLifeSupport.cfg", but somehow the combined presence of a ModuleGenerator-Module (Fuel Cell) and the TacGenericConverter-Module in the SM/AvionicsRing part.cfg caused some wired behavior of the SM on Launchpad. It was forced to decouple from the capsule once the vessel was loaded.

Solution was to remove the Fuel Cell module from part.cfg or add this to the MM_patch file for each, the SM and Avionics Ring. If you don't want to lose the Fuel Cell function:

-MODULE[ModuleGenerator] {}

MODULE
{
    name = TacGenericConverter
    converterName = Fuel Cell
    conversionRate = 86400
    inputResources = LiquidFuel, 0.009, Oxidizer, 0.011
    outputResources = ElectricCharge, 10, true
}

*Edit I was wrong about that, It is the combination of ModuleDecouple and TacGenericConverter in one part.cfg. If the decoupler is set to "stage=true" it makes the decoupler fires every second, once the vessel is loaded. Only found solution is to set "stage=false" as long TacGenericConverter modules are used in the same cfg.

sumghai commented 10 years ago

The Service Module / Avionics Ring decouplers are by default already set to staged = false, and would thus sidestep the reported issue in the first place.

The default setting of false is to prevent overzealous users from accidentally decoupling their pod before performing a retroburn, and thus force them to make a conscious decision by using the right-click GUI context menu option or via Action Groups; I cannot offer support or claim responsibility for users who knowingly forgo the recommended defaults.

sumghai commented 10 years ago

That being said, I'm tempted to switch to TacGenericConverter for the Fuel Cell, if only for consistency with the other converters. I'll see how it goes.