sumghai / SDHI_ServiceModuleSystem

Parts pack for Kerbal Space Program that consists of a stockalike Service Module and accessories inspired by NASA’s Orion MPCV, and designed specifically for use with the stock Mk1-3 Command Pod.
Other
23 stars 9 forks source link

Rework side fairings and jettison behaviour #94

Closed sumghai closed 8 years ago

sumghai commented 8 years ago

Forum user Bomoo noticed there was a gap when two side fairings were mounted onto the Service Module:

http://images.akamai.steamusercontent.com/ugc/261587080048769047/ADD009943D8FB6019D466CCCD4C674E981C3D810/

I suspect this came about from the collider rework, and at the time I was trying to avoid explosions from intersecting fairings. But perhaps I can just move the visual mesh to line up properly.

sumghai commented 8 years ago

Bomoo confirmed the commit fixes this issue.

Closing.

sumghai commented 8 years ago

Aforementioned fixes failed regression testing (#95), and requires rework.

sumghai commented 8 years ago

The fairings need a fundamental rework, and so I've renamed the issue.

sumghai commented 8 years ago

Taking a page from forums user Sobol's SLS pack, I've reworked the side fairings as follows:

sumghai commented 8 years ago

Bomoo confirms new side fairing behaviour works as intended.

This is good to go.