search

sumhungyee / pe

0 stars 0 forks source link

Inconsistent invalid index formats #3

Open sumhungyee opened 1 year ago

sumhungyee commented 1 year ago

image.png

image.png

Note that delete student 99999999999999999 will not be treated as an inconsistency because that is not an integer (long)

nus-pe-script commented 1 year ago

Team's Response

There should be no issue with the errors "invalid command format" and "invalid index" as they mean the same thing.

As you mentioned, "Note that delete student 99999999999999999 will not be treated as an inconsistency because that is not an integer (long)"

-1 is not considered a positive integer which is why it is "invalid command format"

Whereas 999999 is considered a positive integer, the app tries to find student of index 999999 but there is no student with index 999999.

This works as intended.

"If the problems can only happen in case of deliberate sabotage (e.g., user entered a 30-digit telephone number), in which case it should not be considered a bug."

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png STUDENT_INDEX is not mentioned to be restricted to a positive integer. Therefore, there should be no distinction between an invalid index 99999 and an invalid index -1.

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** Should be a documentation bug as this is about how error messages are presented