sumikchakka / jallib

Automatically exported from code.google.com/p/jallib
0 stars 0 forks source link

GLCD refactoring #150

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
There are currently at least 3 GLCD libraries, but each is using its own way to 
deal with fonts & pixel-based drawings, and API isn't normalized.

TODO (unordered):

- font libs must be named the same (glcd_font_WxH or glcd_font_HxW)
- glcd_nokia_3310 needs lcd_write_pixel() implementation
- check memory/stack usage during refactoring

Original issue reported on code.google.com by sebastie...@gmail.com on 21 Feb 2011 at 8:39

GoogleCodeExporter commented 9 years ago
Code involved in this refactoring will stay in project/glcd_cache so current 
release isn't disturb.

Original comment by sebastie...@gmail.com on 21 Feb 2011 at 8:40

GoogleCodeExporter commented 9 years ago
There are two main ways to use GLCD:
  - char-based stuff
  - pixel-based stuff

I suggest every char-based proc/func go to glcd_font.jal. All pixel-based 
proc/func could remain in glcd_common.jal (maybe renamed).

Ex: lcd_set_cursor(row,col) is char-based, because args correspond to row/col 
in a grid defined by font width * height. It's not named appropriately. And 
maybe it could go to glcd_font.jal

Ex2: in nokia 3310 lib, there's a lcd_gotoxy(x,y). This time pixel based. Maybe 
this procedure could be part of standard API, meaning every GLCD lib should 
implement it. 

Original comment by sebastie...@gmail.com on 21 Feb 2011 at 9:25

GoogleCodeExporter commented 9 years ago
I'd like to get this fixed too.  The jallib-pack-bee download doesn't even have 
the nokia library.  How are people using the Nokia with JAL?  The libs I'm 
using aren't in the jallib pack.

Original comment by mke...@gmail.com on 12 Dec 2012 at 10:33